Various improvements on JS backend #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeclerck
reviewed
Jun 2, 2024
src/stubs/ml_canvas.js
Outdated
| } | ||
|
|
||
| // willReadFrequently needed to avoid warning on getImageData | ||
| var ctxt = surface.getContext("2d", {willReadFrequently: true}); |
There was a problem hiding this comment.
According to the doc, this force usage of a software renderer:
https://developer.mozilla.org/en-US/docs/Web/API/HTMLCanvasElement/getContext#willreadfrequently
ddeclerck
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes are:
resizeableoption).body.Also, disabled decorations entirely in this backend, as it doesn't fit browser/webapp UX design.
A note on restoring shortcuts : The issue was related to event default action unable to trigger unless eventListeners were set to
passive. This indicates that OcamlCanvas eventListener are not terminating properly, but I was unable to understand if that was actually the case and why. I suspect it has something to do with the wayBackend.runworks but I can't be sure.Either way, the proposed solution is not ideal as it will hinder the user to actually prevent default action when needed.